Skip to content

SMB: Implement encryption, cleanup RequireSignature#4643

Merged
gpotter2 merged 1 commit intosecdev:masterfrom
gpotter2:smb-encryption
Feb 3, 2025
Merged

SMB: Implement encryption, cleanup RequireSignature#4643
gpotter2 merged 1 commit intosecdev:masterfrom
gpotter2:smb-encryption

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Jan 19, 2025

This PR:

  • adds SMB encryption.
  • cleans up how and when signature is required by the client and server, failing in cases where it should fail.

@codecov
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 84.95146% with 31 lines in your changes missing coverage. Please review.

Project coverage is 81.65%. Comparing base (8fef083) to head (98e6384).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/smb2.py 87.93% 14 Missing ⚠️
scapy/layers/smbclient.py 74.19% 8 Missing ⚠️
scapy/layers/smbserver.py 84.61% 8 Missing ⚠️
scapy/layers/ntlm.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4643      +/-   ##
==========================================
+ Coverage   81.34%   81.65%   +0.30%     
==========================================
  Files         359      359              
  Lines       86242    86425     +183     
==========================================
+ Hits        70155    70570     +415     
+ Misses      16087    15855     -232     
Files with missing lines Coverage Δ
scapy/layers/smb.py 76.70% <100.00%> (+0.33%) ⬆️
scapy/layers/ntlm.py 87.15% <50.00%> (-0.15%) ⬇️
scapy/layers/smbclient.py 74.12% <74.19%> (-0.27%) ⬇️
scapy/layers/smbserver.py 72.75% <84.61%> (+1.78%) ⬆️
scapy/layers/smb2.py 88.08% <87.93%> (+0.79%) ⬆️

... and 17 files with indirect coverage changes

@gpotter2 gpotter2 merged commit f6ba322 into secdev:master Feb 3, 2025
23 checks passed
@gpotter2 gpotter2 deleted the smb-encryption branch February 3, 2025 19:26
Signed-By: gpotter2 <10530980+gpotter2@users.noreply.github.com>
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant